Trigger policy before log

[snaggen]

Re-arrange rolling file appender, so that it applies the policy
before it writes the next log row.

Fixes #289

[estk]

Seems good, can you add two tests:

• Test that it fixes the problem with the date triggers
• Test that it doesn't break size triggers

One thing to note here is that the .process method does the rolling, looking at the code I think we won't have a race with the background rotation stuff but it will be good to have a test that uses background_rotation, and triggers the roll and immediately writes another log to be sure it doesn't get lost in the churn

[snaggen]

Busy with other stuff right now, but I will try to add some tests when I find the time

[estk]

Thanks @snaggen, really appreciate your work here.

[brotskydotcom]

Hi @snaggen, would you be OK if I tried adding the tests that @estk is asking for? I have a time-based trigger that needs your fix so I'd like to help get it merged.

[snaggen]

Go ahead

[bconn98]

@brotskydotcom Any luck with your tests?

[Dirreke]

@brotskydotcom Any luck with your tests?

I think it's just like what I have done in my PR #296, which you said that should be changed back. @bconn98

[brotskydotcom]

Hey folks, sorry to take a while to get back on this. I had pulled this fix into a separate branch that I've been using in another product and never got back to these tests. I can probably try getting the tests done this week. But @Dirreke are you saying you already have tests for this? Or that you have already integrated this fix into your PR which is waiting to be pulled?

[estk]

I'm assuming this feature was necessary to get the first line of 3rd party time-loggers working, therefore closing in favor of #296 , lets continue discussion over there.