Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance/debug pause breakpoint #997

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Conversation

brianignacio5
Copy link
Collaborator

Description

Pause program execution when trying to set a breakpoint during execution

Fixes #958

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Steps to test this pull request

Provide a list of steps to test changes in this PR and required output

  1. Click on F5 to start debugging a esp-idf application
  2. When the program is running, try to set a breakpoint. The program will pause.
  3. Observe results.
  • Expected behaviour:

After breakpoint is set when program is running, the program execution should be paused and the breakpoint is set.

  • Expected output:

How has this been tested?

Manual testing using blink example.

Test Configuration:

  • ESP-IDF Version: 5.0
  • OS (Windows,Linux and macOS): macOS

Dependent components impacted by this PR:

  • ESP Debug Adapter

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@brianignacio5 brianignacio5 self-assigned this Jun 19, 2023
@brianignacio5 brianignacio5 force-pushed the enhance/debug-pause-breakpoint branch from 34cc587 to 38658a0 Compare June 19, 2023 10:53
@github-actions
Copy link

Download the artifacts for this pull request:

@brianignacio5 brianignacio5 merged commit 53f1e07 into master Jun 29, 2023
@brianignacio5 brianignacio5 deleted the enhance/debug-pause-breakpoint branch June 29, 2023 06:07
@brianignacio5 brianignacio5 added this to the 1.6.4 milestone Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot add breakpoint if running. (VSC-1101)
2 participants