Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add enableSizeTaskAfterBuildTask setting #965

Merged
merged 1 commit into from
May 23, 2023

Conversation

brianignacio5
Copy link
Collaborator

@brianignacio5 brianignacio5 commented May 6, 2023

Description

Add idf.enableSizeTaskAfterBuildTask to enable or disable the IDF Size task after the build task.

Fixes #954

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Steps to test this pull request

Provide a list of steps to test changes in this PR and required output

  1. Open any ESP-IDF project.
  2. Click on "ESP-IDF: Build your project" command and check that the IDF Size task is executed. This is the default behavior.
  3. Set idf.enableSizeTaskAfterBuildTask: false in settings.json.
  4. Click on "ESP-IDF: Build your project" command and check that the IDF Size task is not executed.

How has this been tested?

Manual testing

Test Configuration:

  • ESP-IDF Version: 5.0
  • OS (Windows,Linux and macOS): macOS

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@brianignacio5 brianignacio5 self-assigned this May 6, 2023
@github-actions
Copy link

github-actions bot commented May 6, 2023

Download the artifacts for this pull request:

@radurentea
Copy link
Collaborator

LGTM

@brianignacio5 brianignacio5 merged commit 019e692 into master May 23, 2023
@brianignacio5 brianignacio5 deleted the enhance/enable-size-task branch May 23, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants