fix env path in windows and python on terminal (VSC-319) #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
seems like it fixed issue.... maybe merge into master asap and release v0.2.2 |
pwmb
reviewed
May 13, 2020
igrr
reviewed
May 14, 2020
79d1856 to
82b45ab
Compare
82b45ab to
045ef3a
Compare
pwmb
approved these changes
May 17, 2020
pwmb
reviewed
May 20, 2020
| @@ -51,7 +51,7 @@ export class AppTraceArchiveTreeDataProvider | |||
| return this.appTraceArchives; | |||
| } | |||
| public refresh() { | |||
| this.OnDidChangeTreeData.fire(); | |||
| this.OnDidChangeTreeData.fire(null); | |||
There was a problem hiding this comment.
@brianignacio5 I tried (latest changes) without passing null it compiles fine and run as expected.
What is the error you got here ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #93, #100
Normalize modifiedEnv PATH and Path updating.
Also fix wrong python picked from ESP-IDF Terminal (should use the virtualenv)