Updated esp-matter checkout submodules arguments (VSC-1076) #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Platform is required to correctly checkout all submodules Also, the checkout proccess now is executed in the Matter folder
|
Thanks for your contribution ! We need to add a validation to only allow to use |
|
Woah! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since espressif/esp-matter@7b2912a, platform is requested for checking out matter submodules in a lightweight way (So only esp32 submodules).
This change was also applied to ESP-Matter repo in this commit: espressif/esp-matter@ca1258f
Type of change
Bug fix (non-breaking change which fixes an issue)
Steps to test this pull request
All is run without any problem
Checklist