Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add monitor no reset flag #914

Merged
merged 7 commits into from
Apr 4, 2023
Merged

add monitor no reset flag #914

merged 7 commits into from
Apr 4, 2023

Conversation

brianignacio5
Copy link
Collaborator

@brianignacio5 brianignacio5 commented Mar 21, 2023

Description

Fix Monitor resetting the chip when debug session starts. This is done by adding --no-reset to IDF Monitor when debug session starts if idf.launchMonitorOnDebugSession is true (for IDF 5.0 or newer) and using a idf.monitorStartDelayBeforeDebug delay (in ms) to wait IDF Monitor is ready before debug session starts. (For IDf <5.0 need to modify this value)

add idf.monitorNoReset to enable or disable --no-reset flag for IDF Monitor and idf.monitorStartDelayBeforeDebug to set a delay to start debug session after IDF Monitor.

Fix #922

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature

How has this been tested?

Tested using the debug session with IDF monitor with the idf.monitorNoReset set to true.

  • Manual testing of debug blink example

Test Configuration:

  • ESP-IDF Version: 5.1
  • OS (Windows,Linux and macOS): macOS

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@github-actions
Copy link

github-actions bot commented Mar 21, 2023

Download the artifacts for this pull request:

@brianignacio5 brianignacio5 marked this pull request as ready for review March 23, 2023 08:20
@brianignacio5 brianignacio5 self-assigned this Mar 23, 2023
@brianignacio5 brianignacio5 added the bugfix Fixing some issue and bug in this PR label Mar 23, 2023
@brianignacio5 brianignacio5 added this to the 1.6.1 milestone Mar 23, 2023
Copy link
Collaborator

@radurentea radurentea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brianignacio5 brianignacio5 merged commit 370d615 into master Apr 4, 2023
@brianignacio5 brianignacio5 deleted the bugfix/monitor-no-reset branch April 4, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixing some issue and bug in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: add settings for --no-reset when running Monitor (VSC-1074)
2 participants