Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix terminal output close bugs #291

Merged
merged 2 commits into from
Jan 19, 2021
Merged

Conversation

brianignacio5
Copy link
Collaborator

Fix task output parsing for extension tasks on Windows.
Fix emit close event code !== 0

Fix #287
Fix #290

@Elijahg
Copy link

Elijahg commented Jan 19, 2021

This seems to be broken for me. Whilst the "building" notification does now disappear upon failure, the terminal now behaves more similarly to the non-VSCode one in that the build status no longer has a newline for each completed file, and just overwrites the existing line. This is fine, but it doesn't work properly in VSCode as it just keeps overwriting part of the existing line rather than clearing the whole line:

Screen.Recording.2021-01-18.at.20.22.48.mp4

Presumably as a result of this, the build failure messages are also pushed onto that single line, so it's impossible to see the error causing the build to fail, and the "problems" view in VSCode shows nothing. In a non-VSCode terminal the errors are written properly onto separate lines.

@brianignacio5 brianignacio5 merged commit 5826db8 into master Jan 19, 2021
@brianignacio5 brianignacio5 added this to the v0.6.1 milestone Jan 19, 2021
@brianignacio5 brianignacio5 deleted the bugfix/custom-terminal branch May 8, 2021 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixing some issue and bug in this PR
Projects
None yet
3 participants