Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm check tools before cmds update tasks #281

Merged
merged 1 commit into from
Jan 7, 2021
Merged

Conversation

brianignacio5
Copy link
Collaborator

@brianignacio5 brianignacio5 commented Jan 7, 2021

Fix #280
Fix #278
Fix #277
Fix #276

Add env:PATH and reorder monitor args in tasks.json
Fix quotes on cmd.exe
Remove check esp-idf tools are valid from build flash commands.

@brianignacio5 brianignacio5 requested a review from pwmb January 7, 2021 08:39
@pwmb pwmb added this to the v0.6.1 milestone Jan 7, 2021
@pwmb pwmb added the bugfix Fixing some issue and bug in this PR label Jan 7, 2021
@brianignacio5 brianignacio5 merged commit 03db8d3 into master Jan 7, 2021
@gost-serb
Copy link

    if (canAccessCMake === "" && canAccessNinja === "") {
      throw new Error("CMake or Ninja executables not found");
    }

the condition doesn't match exception descriptions. I suggest it should be || instead of &&.

@gost-serb
Copy link

I also propose to add -b ${config:idf.flashBaudRate} into monitor task to make its behavior similar to the rest of the tasks.

@brianignacio5
Copy link
Collaborator Author

brianignacio5 commented Jan 8, 2021

@GOST-UA Tasks.json monitor task can be modified by user after project creation and the monitor baud rate can be configured in the SDK Configuration Editor with CONFIG_ESPTOOLPY_MONITOR_BAUD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment