-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VSC-1568] get supported qemu targets from tools json #1405
base: master
Are you sure you want to change the base?
Conversation
Download the artifacts for this pull request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked using Windows and Mac connected to docker container.
The QEMU emulation is failing for esp32c3, and esp32s3 is missing form the json file, but manually adding the target allows the extension to send the command to QEMU.
The issue is related to ESP-EDF, no side effected detected on the VSCOde extension.
I've tested with ESP32C3 and QEMU monitor worked.
|
Description
Use
$IDF_PATH/tools/tools.json
to obtain QEMU forks supported targets. From now any IDF_TARGET is mapped to them and fallback to esp32 and esp32c3 forks.Fixes #1404
Type of change
Steps to test this pull request
Provide a list of steps to test changes in this PR and required output
Expected behaviour:
Expected output:
How has this been tested?
Manual testing running any QEMU command (Debug, Monitor) to make sure IDF_TARGET is used to get the QEMU fork to use (xtensa or risc-v)
Test Configuration:
Checklist