-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VSC-1514] add idf path idf tools path to created example #1332
Conversation
Download the artifacts for this pull request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed drop down list of available IDF installations when showing examples or starting a new project.
Tested on Windows and Linux.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left comment for a small change related to translations.
Other than that LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
ESP-IDF: Show Examples
framework selection dropdown.ESP-IDF: New Project
before UI is loaded to select esp-idf to use.ESP-IDF: Show Examples
(when different that esp-idf framework is selected).Type of change
Please delete options that are not relevant.
Steps to test this pull request
Provide a list of steps to test changes in this PR and required output
ESP-IDF: New Project
to select esp-idf versionExpected behaviour:
Selecte esp-idf version from both examples and new project wizard should be saved in new created project settings.json
Expected output:
How has this been tested?
Manual testing with steps from above.
Test Configuration:
Checklist