Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update recommended cp command #1269

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

radurentea
Copy link
Collaborator

Description

Updated the command we tell our Linux users to use in order to add 60-openocd.rules for permission delegation in USB devices to be added in /etc/udev/rules.d/

Fixes #1256

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Steps to test this pull request

  1. Configure extension on Linux
  2. After configuration it's done the command we show should be:
    sudo cp --update=none /home/hmp/.espressif/tools/openocd-esp32/v0.12.0-esp32-20240318/openocd-esp32/share/openocd/contrib/60-openocd.rules /etc/udev/rules.d

Previously the command was:
sudo cp -n /home/hmp/.espressif/tools/openocd-esp32/v0.12.0-esp32-20240318/openocd-esp32/share/openocd/contrib/60-openocd.rules /etc/udev/rules.d

How has this been tested?

As described above.

Test Configuration:

  • ESP-IDF Version: 5.3
  • OS (Windows,Linux and macOS): Linux

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@radurentea radurentea self-assigned this Aug 2, 2024
Copy link

github-actions bot commented Aug 2, 2024

Download the artifacts for this pull request:

Copy link
Collaborator

@brianignacio5 brianignacio5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@radurentea
Copy link
Collaborator Author

Hi @AndriiFilippov, PTAL

Copy link

Pull request has been marked as stale since there are no activities, and this will be closed in 5 days if there are no further activities

@github-actions github-actions bot added the stale Stale PR or Issue label Aug 21, 2024
@radurentea radurentea added ongoing Ongoing Issue or PR, this label will be used for issue or PR which is to be excluded by stale bot and removed stale Stale PR or Issue labels Aug 21, 2024
@radurentea
Copy link
Collaborator Author

Hi @Fabricio-ESP , PTAL

@brianignacio5 brianignacio5 added this to the 1.9.0 milestone Sep 10, 2024
@Fabricio-ESP
Copy link
Collaborator

Message updated successfully on the ESP-IDF Setup screen displayed by the extension after finishing the configuration step:

image

@brianignacio5 brianignacio5 merged commit b8cda55 into master Sep 24, 2024
6 checks passed
@brianignacio5 brianignacio5 deleted the bugfix/update-recommended-cp-command branch September 24, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ongoing Ongoing Issue or PR, this label will be used for issue or PR which is to be excluded by stale bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cp command does not take -n anymore (VSC-1441)
3 participants