Fix CMake args for esp-idf lower than 4.4 #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request: |
brianignacio5
requested changes
Aug 1, 2024
|
@brianignacio5 Please take another look, I've fixed the things you've requested. I've also tested the implementation with esp-idf version 4.3.6 |
|
Hi @AndriiFilippov, this is ready to be tested PTAL |
|
@radurentea hi ! Tested under: able to build / flash / monitor projects with versions lower than 4.4 ✅ LGTM 👍 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed.
Fixes #1260
Type of change
Steps to test this pull request
The project should build with no issues.
How has this been tested?
Manual testing
Test Configuration:
Checklist