-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prefer computed python venv path #1263
Conversation
Download the artifacts for this pull request: |
6475198
to
dc09c1b
Compare
dc09c1b
to
cbc83a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments related to small changes in the documentation, other than that, LGTM!
c4d6eeb
to
f2710de
Compare
Pull request has been marked as |
fd2b826
to
727b8d0
Compare
Confirmed working on Windows and Linux for upgrading current installation and for new installation of the extension. |
Description
Remove
idf.pythonBinPath
,idf.adapterTargetName
,idf.customAdapterTargetName
,idf.customExtraPaths
,idf.selectedDfuDevicePath
andidf.listDfuDevices
in favor of calculating them from IDF_PATH and IDF_TOOLS_PATH.Doctor command now computes ESP-IDF tools to be added in PATH and the used venv from IDF_PATH and IDF_TOOLS_PATH.
This should improve maintenance of extension, reduce setup issues and reduce regular docker file updates.
Type of change
Steps to test this pull request
This PR changes impact all the extension. It is necessary a full extension review for this PR to review avoid breaking existing features.
A basic test flow should include: Configure ESP-IDF extension, create project, build, flash monitor and debug as described in documentation.
Other features that requires ESP-IDF Tools or Virtual environment Python should also be review like: App Tracing, IDF Size UI and others. Doctor command now
Expected behaviour: All extension features work the same as before but used settings are less than before.
Expected output:
How has this been tested?
Ideally user should test this PR with all main features by following commands. A basic test flow should include: Configure ESP-IDF extension, create project, build, flash monitor and debug as described in documentation.
Test Configuration:
Checklist