Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm mount from devcontainer json template #1200

Merged
merged 3 commits into from
May 30, 2024

Conversation

brianignacio5
Copy link
Collaborator

@brianignacio5 brianignacio5 commented May 23, 2024

Description

Remove mount settings from devcontainer.json since they are not necessary. update docker file userid to avoid conflict with default user id.

Fixes #1190
Fixes #1201

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Steps to test this pull request

Provide a list of steps to test changes in this PR and required output

  1. Create any ESP-IDF project from examples or New Project Wizard.
  2. Open folder in container by running Dev Containers: Open Folder in Container command.
  3. Observe results. The container should build without errors.

How has this been tested?

Manual testing when creating a project using docker containers.

Test Configuration:

  • ESP-IDF Version: 5.3
  • OS (Windows,Linux and macOS): Windows MacOS

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@brianignacio5 brianignacio5 added this to the v1.8.0 milestone May 23, 2024
@brianignacio5 brianignacio5 self-assigned this May 23, 2024
Copy link

github-actions bot commented May 23, 2024

Download the artifacts for this pull request:

@brianignacio5
Copy link
Collaborator Author

PTAL @AndriiFilippov

@AndriiFilippov
Copy link
Collaborator

@brianignacio5 hi !

Tested under:
OS - Windows 10
ESP-IDF: v5.2.1

able to Open Folder in Container and build project 👍
LGTM 👍

@brianignacio5 brianignacio5 merged commit fe2bb94 into master May 30, 2024
6 checks passed
@brianignacio5 brianignacio5 deleted the feature/devcontainer-fix branch May 30, 2024 08:20
@HaydenDekker
Copy link

Morning, love the tool.

I'm using the current VS ESP-IDF ext v1.8.0 and just wondering about the use case for the tool with the unique user name. I'm having trouble with the user permissions so wondering if I'm using the tool incorrectly.

I've created the base project with my host user id 1000 as the file and group owner of the project and subfiles. After the project is created I use the devcontainers extension (previously Remote Containers ext) to open the folder in the QEMU docker container supplied by the ESP-IDF extension. When I go to run the server using command ESP-IDF – Launch QEMU Server I get permission denied as the container cannot write the merged-qemu.bin to the folder owned by the host user.

I resolved the issue by setting the folder and contents as in-secured with a 'chmod -R 777 ./'. After doing so launching the QEMU server succeeded.

Thankyou very much for you help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants