-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance/whitespaces2 #1159
Enhance/whitespaces2 #1159
Conversation
Download the artifacts for this pull request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest to rebase this branch to current master to remove changes that doesn't belong to the PR and keep changes related to feature being introduced.
536b9fa
to
3bd570b
Compare
Need to update the monitor code because this doesn't work.
|
PTAL @AndriiFilippov |
- Replaced Shell Executions task type with Process Executions - Modified a bit the code for consistency in the project (replacing, workspace variable name to workspaceUri because there is a vscode.workspace an this two can be confused if we import "workspace" from "vscode" specifically.
From workspace to workspaceUri
TODO: UI changes to let user know it only work on version of esp-idf 5.0 and higher
Fix typo for espBom :art: Fix formatting
🎨 Fix formatting
Use CMake Bin Path for building
If user doesn't have default terminal set, we just use the default ones for each os
cdd0b27
to
1b595d3
Compare
@radurentea hi ! Tested under: |
Hi @AndriiFilippov, The error you receive is because idf tools' path contains whitespaces and currently whitespaces can only be present in esp idf and project's path. However, it seems that we show all errors under esp-idf path. I will work on a fix so that user sees the error under tools' path and also if errors are being displayed the install button will be disabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One doc comment but otherwise LGTM
@AndriiFilippov PTAL, I've added UI Validation. |
@radurentea hi ! Tested under: Tools PATH validation ✔️ able to create / build / flash / monitor / debug project ✔️ LGTM 👍 |
Description
Enable usage of white spaces in project's path, esp idf's path and tools's path.
https://jira.espressif.com:8443/browse/VSC-808
Fixes #1162
Fixes #939
Type of change
Please delete options that are not relevant.
Steps to test this pull request
Provide a list of steps to test changes in this PR and required output
All features should work, however, there is an issue currently with esp-idf while building a project with whitespaces:
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Tested as described above on Windows 11 with different shells, including: Command Prompt, Powershell and Bash
Test Configuration:
Checklist