Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✏️ Add clarity to placeholder flash method #1142

Merged

Conversation

radurentea
Copy link
Collaborator

Description

Added a bit more clarity to the placeholder text that is shown when choosing Flashing Method:

Old text: "Select flash method, you can modify the choice later from settings 'idf.flashType'"

New text: "Select flash method, you can modify the choice later from 'settings.json' (idf.flashType)"

Task: https://jira.espressif.com:8443/browse/VSC-1235

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Steps to test this pull request

  1. Open Project
  2. Change Flash Method

In the menu that appears, the new text should be present.

Test Configuration:

  • ESP-IDF Version: Latest
  • OS (Windows,Linux and macOS): Windows

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

Copy link

github-actions bot commented Feb 19, 2024

Download the artifacts for this pull request:

Copy link
Collaborator

@brianignacio5 brianignacio5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Mar 6, 2024

Pull request has been marked as stale since there are no activities, and this will be closed in 5 days if there are no further activities

@github-actions github-actions bot added the stale Stale PR or Issue label Mar 6, 2024
@github-actions github-actions bot closed this Mar 11, 2024
@radurentea radurentea added ongoing Ongoing Issue or PR, this label will be used for issue or PR which is to be excluded by stale bot and removed stale Stale PR or Issue labels Apr 4, 2024
@radurentea radurentea reopened this Apr 8, 2024
@AndriiFilippov
Copy link
Collaborator

@radurentea hi !

LGTM 👍

@radurentea radurentea merged commit d13f179 into master Apr 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ongoing Ongoing Issue or PR, this label will be used for issue or PR which is to be excluded by stale bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants