-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rm gcovr dep implement json html report #1099
Conversation
fcb60e1
to
fb5daa5
Compare
Download the artifacts for this pull request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from a coding perspective.
However, I have the following suggestions for the design:
-
The black font on the red background in the HTML Report is quite hard too see:
-
For the columns that don't have values we should leave them empty or put "0%" instead of "-%"
-
I think this is a bug, in old HTML Report the map value was "low: <75.0 %" instead of "low: >= 0%"
-
We should update the screenshots as well for the gcov documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@brianignacio5 hi ! Tested: LGTM 👍 |
Updated the HTML report picture and removed gcovr from docs |
LGTM 👍 |
Description
Remove
gcovr
use in the extension in favor of implementing our own JSON and HTML report from toolchain gcov executables.Type of change
Steps to test this pull request
Provide a list of steps to test changes in this PR and required output
ESP-IDF: Add Editor Coverage
andESP-IDF: Get HTML Coverage Report for Project
should provide similar results.How has this been tested?
Manual testing following code coverage tutorial.
Test Configuration:
Checklist