Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix esp32h2 set target on idf446 #1057

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Conversation

brianignacio5
Copy link
Collaborator

@brianignacio5 brianignacio5 commented Oct 13, 2023

Description

Fix VSC-1201 for idf.py set-target esp32h2 on idf 4.4.6.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Steps to test this pull request

Provide a list of steps to test changes in this PR and required output

  1. Click on "ESP-IDF: Set Espressif device target" command.
  2. Select esp32h2.
  3. Observe results. No errors should be found.
  • Expected behaviour:

  • Expected output:

How has this been tested?

Manual testing

Test Configuration:

  • ESP-IDF Version: 4.4.6
  • OS (Windows,Linux and macOS): Windows 11

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@github-actions
Copy link

Download the artifacts for this pull request:

Copy link

github-actions bot commented Nov 2, 2023

Pull request has been marked as stale since there are no activities, and this will be closed in 5 days if there are no further activities

@github-actions github-actions bot added the stale Stale PR or Issue label Nov 2, 2023
@brianignacio5 brianignacio5 removed the stale Stale PR or Issue label Nov 6, 2023
@AndriiFilippov
Copy link
Collaborator

@brianignacio5 hi !

Tested:
OS - Windows 10
ESP-IDF: v4.4.6

LGTM 👍 able to set esp32h2 target without error and build project.

@brianignacio5 brianignacio5 merged commit 154fe29 into master Nov 17, 2023
@brianignacio5 brianignacio5 deleted the bugfix/esp32h2-set-target branch November 17, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants