Add fix for version 5.1.0 or above #1039
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added dynamic arguments based on version being >= 5.1.0
For versions < 5.1.0 it will remain --json, but for >= it will be --format json
Fixes #1033
Type of change
Please delete options that are not relevant.
Steps to test this pull request
Provide a list of steps to test changes in this PR and required output
Test 1
1 - Configure for ESP IDF 5.1.0 or above
2 - Create a new project from the 'blink' template. Select a target
3 - Build project
4 - Run command 'Size analysis of the binaries'
Test 2
1 - Configure for ESP IDF version below 5.1.0
2 - Create a new project from the 'blink' template. Select a target
3 - Build project
4 - Run command 'Size analysis of the binaries'
EXPECT: Binary size analysis panel opens in VS Code
How has this been tested?
I've tested as described above on windows 10.
Test Configuration:
Checklist