Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fix for version 5.1.0 or above #1039

Merged
merged 4 commits into from
Oct 2, 2023
Merged

Add fix for version 5.1.0 or above #1039

merged 4 commits into from
Oct 2, 2023

Conversation

radurentea
Copy link
Collaborator

Description

Added dynamic arguments based on version being >= 5.1.0
For versions < 5.1.0 it will remain --json, but for >= it will be --format json

Fixes #1033

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Steps to test this pull request

Provide a list of steps to test changes in this PR and required output

Test 1
1 - Configure for ESP IDF 5.1.0 or above
2 - Create a new project from the 'blink' template. Select a target
3 - Build project
4 - Run command 'Size analysis of the binaries'

Test 2
1 - Configure for ESP IDF version below 5.1.0
2 - Create a new project from the 'blink' template. Select a target
3 - Build project
4 - Run command 'Size analysis of the binaries'

EXPECT: Binary size analysis panel opens in VS Code

How has this been tested?

I've tested as described above on windows 10.

Test Configuration:

  • ESP-IDF Version: 5.1.0
  • OS (Windows,Linux and macOS): Windows

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@radurentea radurentea self-assigned this Sep 11, 2023
@github-actions
Copy link

github-actions bot commented Sep 11, 2023

Download the artifacts for this pull request:

@kolipakakondal kolipakakondal added this to the v1.7.0 milestone Sep 14, 2023
Copy link
Collaborator

@brianignacio5 brianignacio5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor observation

src/utils.ts Outdated Show resolved Hide resolved
@AndriiFilippov
Copy link
Collaborator

@radurentea hi !

Tested under:
OS - MacOS Ventura
ESP-IDF: v 5.1.1

LGTM 👍

However, I don't see this two buttons works properly.
Screenshot 2023-09-27 at 11 31 47

When click "Flash" button - it asks you to select the flash method only. No flash process was started.
Also, the "Retry" button is seams to be a bit useless or should be renamed because it is difficult to understand the purpose of this button based on name "Retry" .

Copy link
Collaborator

@brianignacio5 brianignacio5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@radurentea radurentea merged commit 7ed86ab into master Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command 'Size analysis of the binaries' fails to open result panel with ESP IDF 5.1.0 or above (VSC-1181)
4 participants