Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix regex in tasks json #1014

Merged
merged 1 commit into from
Aug 3, 2023
Merged

fix regex in tasks json #1014

merged 1 commit into from
Aug 3, 2023

Conversation

brianignacio5
Copy link
Collaborator

@brianignacio5 brianignacio5 commented Jul 25, 2023 •
edited
Loading

Description

Update the tasks.json problem matcher regex.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Steps to test this pull request

Provide a list of steps to test changes in this PR and required output

  1. Create a new project using the Show Examples or New Project Wizard
  2. Execute one of the tasks defined in the tasks.json
  3. Observe results. Problem matcher should capture the errors.

How has this been tested?

Manual testing

Test Configuration:

  • ESP-IDF Version: 5.0
  • OS (Windows,Linux and macOS): macOS

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@brianignacio5 brianignacio5 requested a review from radurentea July 25, 2023 08:53
@brianignacio5 brianignacio5 self-assigned this Jul 25, 2023
@github-actions
Copy link

Download the artifacts for this pull request:

@brianignacio5 brianignacio5 merged commit 14d1b29 into master Aug 3, 2023
@brianignacio5 brianignacio5 deleted the bugfix/tasks-problem-matcher branch August 3, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radurentea radurentea radurentea approved these changes

Assignees

@brianignacio5 brianignacio5

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianignacio5 @radurentea