-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add monthly downloads badge to README (ESPTOOL-876) #986
Conversation
👋 Hello Aman-Clement, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. Click to see more instructions ...
Review and merge process you can expect ...
|
Hello @Aman-Clement, In this case, we don't really care about communicating how many monthly downloads esptool has. Also, this adds a dependency on an external service (piptrends.com). I am sorry, but for this reason and to keep things simple and tidy, we would rather not accept this PR. |
Hey @radimkarnis |
@Aman-Clement thanks for understanding!
Will keep you in mind 😊 |
It not only adds a dependency to an external service but it adds it to one that is not an officially trusted service of pypi. This person tried to open a PR against a project I'm the maintainer for as well (ixmatus/inflector#16). Users can get statistics from |
Added a monthly downloads badge by pip Trends to the README.
View more at - https://piptrends.com/widgets/esptool