-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typos (ESPTOOL-853) #977
Conversation
👋 Hello BoryaGames, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. Click to see more instructions ...
Review and merge process you can expect ...
|
Hello @BoryaGames, To sum up:
The we can merge it! |
Hello @radimkarnis, sorry, can you help me how to change commit message and rebase? I'm not really good with GitHub. |
I would suggest learning some basic workflows with the git versioning system (using a GUI client or on the command line).
|
Done, @radimkarnis, I did what you asked. |
Thank you @BoryaGames, Also, now there are two commits for a single change. Can we get rid of the merge commit? Thank you. |
Done, @radimkarnis. I merged these commits and changed message. |
@BoryaGames thank you for the contribution! Your commit is now merged. |
Just fix typos in comment.
I have tested this change with the following hardware & software combinations:
NO TESTING
I have run the esptool.py automated integration tests with this change and the above hardware:
NO TESTING