[packaging] Exclude also the submodules of test and docs (ESPTOOL-927) #1012
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the wheel build of esptool 4.8.0 in Fedora, the
docs/en/conf.py
andtest/efuse_scripts/*.py
were included in the distribution.Apparently, setuptools excludes only the first level of modules, unless specified otherwise. Following the official documentation, the
Important
part, adding asterisks to exclude all the found submodules does the trickhttps://setuptools.pypa.io/en/latest/userguide/package_discovery.html#finding-simple-packages
I've tested it during the Fedora RPM build and verified this change works for us.