Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mdns): support zero item when update subtype (IDFGH-14369) #726

Conversation

zwx1995esp
Copy link
Contributor

Description

Support zero number of subtype item when updating service. Zero number means remove all subtypes registered.

Copy link
Collaborator

@david-cermak david-cermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please fix the formatting (just run the pre-commit hook)

@zwx1995esp zwx1995esp force-pushed the feature/support_update_zero_item_of_subtype_for_mdns branch from 464bc28 to 5bd82c0 Compare January 7, 2025 03:24
@zwx1995esp
Copy link
Contributor Author

LGTM, but please fix the formatting (just run the pre-commit hook)

Hi, @david-cermak the pipeline has been fixed, PTAL.

@espressif-bot espressif-bot added the Status: Opened Issue is new label Jan 7, 2025
@github-actions github-actions bot changed the title feat(mdns): support zero item when update subtype feat(mdns): support zero item when update subtype (IDFGH-14369) Jan 7, 2025
@david-cermak david-cermak merged commit 7c6a309 into espressif:master Jan 7, 2025
110 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants