Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix export.sh failure if python 2.x is unavailable (IDFGH-8261) #9749

Closed
wants to merge 2 commits into from

Conversation

gormster
Copy link
Contributor

@gormster gormster commented Sep 8, 2022

In the latest release of macOS (and probable some other recent *nixes as well?) python is no longer available by default, only python3. This causes export.sh to fail as it still had a reference to plain python. This now works as expected.

In the latest release of macOS (and probable some other recent *nixes as well?) `python` is no longer available by default, only `python3`. This causes `export.sh` to fail as it still had a reference to plain `python`. This now works as expected.
@CLAassistant
Copy link

CLAassistant commented Sep 8, 2022

CLA assistant check
All committers have signed the CLA.

@espressif-bot espressif-bot added the Status: Opened Issue is new label Sep 8, 2022
@github-actions github-actions bot changed the title Fix export.sh failure if python 2.x is unavailable Fix export.sh failure if python 2.x is unavailable (IDFGH-8261) Sep 8, 2022
@Alvin1Zhang
Copy link
Collaborator

Thanks for your contribution.

@dobairoland
Copy link
Collaborator

Hi @gormster. The change looks good to me. Thanks! Could you please apply the same patch to export.fish as well? Please apply it to the same commit (git commit --amend).

@gormster
Copy link
Contributor Author

gormster commented Sep 8, 2022

@dobairoland ah yes, of course! can't forget the fish people. you can't amend commits once they've been pushed, though - I'll add a new commit to the same branch.

Same as previous commit but for `export.fish`
@dobairoland
Copy link
Collaborator

@gormster Commit can be amended even after that. One has to do forced push after. Please try to squash the commits into one so we could accept your commit as is and merge this. We prefer to not have multiple commits for simple things belonging together. Thanks for understanding!

You can do this by interactive rebase, i.e. git rebase -i origin/master and by marking the second commit for squashing or fixup. You will also need to do git push --force after that.

@dobairoland
Copy link
Collaborator

sha=f904345b67d8d8df6297c30087bea746c18bf6db

@dobairoland dobairoland added the PR-Sync-Rebase Pull request sync as rebase commit label Sep 14, 2022
@espressif-bot espressif-bot added Status: In Progress Work is in progress and removed Status: Opened Issue is new labels Sep 14, 2022
@dobairoland
Copy link
Collaborator

I'm squashing the commits by myself internally.

@espressif-bot espressif-bot added Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally Resolution: Done Issue is done internally and removed Status: In Progress Work is in progress Resolution: NA Issue resolution is unavailable labels Sep 14, 2022
espressif-bot pushed a commit that referenced this pull request Sep 15, 2022
In the latest release of macOS (and probable some other recent *nixes as well?) `python` is no longer available by default, only `python3`. This causes `export.sh` to fail as it still had a reference to plain `python`. This now works as expected.

Merges #9749
@dobairoland
Copy link
Collaborator

20487e7

espressif-bot pushed a commit that referenced this pull request Sep 22, 2022
In the latest release of macOS (and probable some other recent *nixes as well?) `python` is no longer available by default, only `python3`. This causes `export.sh` to fail as it still had a reference to plain `python`. This now works as expected.

Merges #9749
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Sync-Rebase Pull request sync as rebase commit Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants