-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix export.sh failure if python 2.x is unavailable (IDFGH-8261) #9749
Conversation
In the latest release of macOS (and probable some other recent *nixes as well?) `python` is no longer available by default, only `python3`. This causes `export.sh` to fail as it still had a reference to plain `python`. This now works as expected.
Thanks for your contribution. |
Hi @gormster. The change looks good to me. Thanks! Could you please apply the same patch to |
@dobairoland ah yes, of course! can't forget the fish people. you can't amend commits once they've been pushed, though - I'll add a new commit to the same branch. |
Same as previous commit but for `export.fish`
@gormster Commit can be amended even after that. One has to do forced push after. Please try to squash the commits into one so we could accept your commit as is and merge this. We prefer to not have multiple commits for simple things belonging together. Thanks for understanding! You can do this by interactive rebase, i.e. |
sha=f904345b67d8d8df6297c30087bea746c18bf6db |
I'm squashing the commits by myself internally. |
In the latest release of macOS (and probable some other recent *nixes as well?) `python` is no longer available by default, only `python3`. This causes `export.sh` to fail as it still had a reference to plain `python`. This now works as expected. Merges #9749
In the latest release of macOS (and probable some other recent *nixes as well?) `python` is no longer available by default, only `python3`. This causes `export.sh` to fail as it still had a reference to plain `python`. This now works as expected. Merges #9749
In the latest release of macOS (and probable some other recent *nixes as well?)
python
is no longer available by default, onlypython3
. This causesexport.sh
to fail as it still had a reference to plainpython
. This now works as expected.