Tools: fix idf.py monitor reset with hotkey with --no-reset arg (IDFGH-7375) #8955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution. |
|
Hi @nonoo. Oh I see it now. I assumed this was a mistake. I'm afraid the same mistake could happen in the future. Could you add this into the Something like the following: if not self.gdb_exit and self.reset:
...
elif not self.reset:
... |
|
|
|
But the hotkey reset is not working for you because the DTR/RTS signals were not left at the right state after the port has been opened. Or am I missing something? |
…needed This lets use the reset hotkey (Ctrl+T Ctrl+R). Tools: fix idf.py monitor reset with hotkey with --no-reset arg Tools: Set idf.py monitor DTR to the default state when reset is not needed
7c09e94 to
c063cbd
Compare
|
Thanks for the update! |
|
sha=c063cbd7f7d0996fbaab3d97c8011f216576c8fc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous --no-reset PR (#8788) was not merged completely. Without this patch, the hotkey reset in idf.py monitor (ctrl+t ctrl+r) does not work when --no-reset argument is used.