led_strip component : fix timing by adding the reset signal (IDFGH-7233) #8827
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
led_strip
component does not implement the required reset signal (280µs) at the end of the colors sequence. The constantWS2812_RESET_US
is indeed defined, but it is not used.A simple example such as the following one demonstrates the problem:
The LED does not light up.
We can see on the logical analyzer that the delay between the bursts is too short (45µs instead of 280µs) :
I resolved this issue by adding another byte to the buffer and the
ws2812_rmt_adapter
uses this additional byte to emit the proper reset signal.With this fix, the signal looks much better :
... and the LED lights up.