Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADC Fix compiling when included from C++ (IDFGH-6804) #8430

Merged
merged 1 commit into from
Feb 24, 2022
Merged

ADC Fix compiling when included from C++ (IDFGH-6804) #8430

merged 1 commit into from
Feb 24, 2022

Conversation

0xFEEDC0DE64
Copy link
Contributor

c++ is stricter with enum types and needs a external "C" for correct linkage

@espressif-bot espressif-bot added the Status: Opened Issue is new label Feb 18, 2022
@github-actions github-actions bot changed the title ADC Fix compiling when included from C++ ADC Fix compiling when included from C++ (IDFGH-6804) Feb 18, 2022
@Alvin1Zhang
Copy link
Collaborator

Thanks for your contribution.

@suda-morris suda-morris added the PR-Sync-Merge Pull request sync as merge commit label Feb 21, 2022
@suda-morris
Copy link
Collaborator

sha=c86fba7919fed086ae3dfd07911d589391cf7e89

@espressif-bot espressif-bot added Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally Resolution: Done Issue is done internally and removed Status: Opened Issue is new Resolution: NA Issue resolution is unavailable labels Feb 24, 2022
@espressif-bot espressif-bot merged commit c86fba7 into espressif:master Feb 24, 2022
@0xFEEDC0DE64 0xFEEDC0DE64 deleted the adc_cpp_fixes branch March 3, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR-Sync-Merge Pull request sync as merge commit Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0xFEEDC0DE64 @Alvin1Zhang @suda-morris @espressif-bot