Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fatfs_create_spiflash_image() feature (IDFGH-6383) (IDFGH-6518) #8169

Conversation

tamisoft
Copy link
Contributor

Open the files in binary mode, and remove the redundant encode.

Fixes #8042

Open the files in binary mode, and remove the redundant encode
@CLAassistant
Copy link

CLAassistant commented Dec 29, 2021

CLA assistant check
All committers have signed the CLA.

@espressif-bot espressif-bot added the Status: Opened Issue is new label Dec 29, 2021
@github-actions github-actions bot changed the title fix fatfs_create_spiflash_image() feature (IDFGH-6383) fix fatfs_create_spiflash_image() feature (IDFGH-6383) (IDFGH-6518) Dec 29, 2021
@Alvin1Zhang
Copy link
Collaborator

Thanks for your contribution.

@dobairoland dobairoland added the PR-Sync-Merge Pull request sync as merge commit label Dec 30, 2021
@dobairoland
Copy link
Collaborator

sha=df2ae4689cd1056bfda67c9dbe08c015da1202aa

@espressif-bot espressif-bot added Resolution: Done Issue is done internally Status: Done Issue is done internally and removed Status: Opened Issue is new labels Jan 3, 2022
@espressif-bot espressif-bot merged commit df2ae46 into espressif:master Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Sync-Merge Pull request sync as merge commit Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 Bugs in new fatfs_create_spiflash_image() feature (IDFGH-6383)
5 participants