ldgen: override LC_ALL to C before running objdump (IDFGH-6231) #7903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a Linux system configured with `zh_CN.UTF-8` as `$LANG`, and running raw cmake command to build the project (rather than using `idf.py build`), output of objdump will be Chinese (like `在归档文件 libesp_pm.a 中`), resulting in parsing error `pyparsing.ParseException: Expected "In archive" (at char 0), (line:1, col:1)` at entity.py line 129. This commit forces objdump to use raw locale setting (`C`), to ensure it always make English output that's able to be parsed.
|
|
|
Thanks for your contribution. |
|
Thank you for the PR. We are moving it into our internal test queue. This PR will be closed when it gets accepted or we will get back to you with requests to update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a Linux system configured with
zh_CN.UTF-8as$LANG, and running raw cmake command to build the project (rather than usingidf.py build), output of objdump will be Chinese (like在归档文件 libesp_pm.a 中), resulting in parsing errorpyparsing.ParseException: Expected "In archive" (at char 0), (line:1, col:1)at entity.py line 129.This commit forces objdump to use raw locale setting (
C), to ensure it always make English output that's able to be parsed.