ftm example: clear FTM_FAILURE_BIT too (IDFGH-6094) #7773
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks for your contribution. |
nachiketkukade
approved these changes
Oct 27, 2021
|
@crackwitz , thanks, the change looks good to me. Does it resolve your issue #7702 ? |
|
No, those are entirely unrelated issues. This patch does not address #7702. This patch addresses (solves) the issue described earlier in this pull request. |
|
Ok, got it. I'll be looking into that issue separately. |
|
Thanks for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once some failure with FTM occurred, the FTM_FAILURE_BIT was set forever and caused
xEventGroupWaitBitsto "fall through" right away, dumping the previous session's report (if the success bit was set by the previous session), before the current session could even finish.All bits need to be cleared (and "handled") if they were set. Instead of explicitly clearing the respective flag after the test, I chose having
xEventGroupWaitBitsclear the flags itself (xClearOnExit) atomically.