Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(vfs) fix wrong args (IDFGH-5692) #7413

Closed
wants to merge 1 commit into from
Closed

(vfs) fix wrong args (IDFGH-5692) #7413

wants to merge 1 commit into from

Conversation

cc-caixf
Copy link
Contributor

I think this is a mistake, so I creat a PR.
Mayebe I was wrong....

@CLAassistant
Copy link

CLAassistant commented Aug 13, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Alvin1Zhang
Copy link
Collaborator

Thanks for your contribution.

@espressif-bot espressif-bot added the Status: Opened Issue is new label Aug 13, 2021
@github-actions github-actions bot changed the title (vfs) fix wrong args (vfs) fix wrong args (IDFGH-5692) Aug 13, 2021
@negativekelvin
Copy link
Contributor

negativekelvin commented Aug 13, 2021 •
edited
Loading

Looks right. While you're there you should move the success message inside the previous block

esp-idf/components/vfs/vfs.c

Line 160 in 940d237

ESP_LOGD(TAG, "esp_vfs_register_fd_range is successful for range <%d; %d) and VFS ID %d", min_fd, max_fd, index);

@dobairoland dobairoland self-requested a review August 16, 2021 07:31
dobairoland
dobairoland approved these changes Aug 16, 2021
View reviewed changes
Copy link
Collaborator

@dobairoland dobairoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix.

@espressif-bot espressif-bot added Status: In Progress Work is in progress and removed Status: Opened Issue is new labels Oct 10, 2021
@AxelLin
Copy link
Contributor

AxelLin commented Oct 21, 2021

This PR is approved 2 months ago, but not yet merge. What's wrong?

@AxelLin
Copy link
Contributor

AxelLin commented Nov 24, 2021

@dobairoland @Alvin1Zhang
Is this PR still valid?
This looks like a bug fix and got approved, I'm wondering is anything block this PR?

@dobairoland
Copy link
Collaborator

@AxelLin We are sorry for the delay. I have reviewed it and it looks good to me. Unfortunately, the internal test got delayed.

@espressif-bot espressif-bot added Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally Resolution: Done Issue is done internally and removed Status: In Progress Work is in progress Resolution: NA Issue resolution is unavailable labels Jan 14, 2022
dskulina pushed a commit to playable-tech/esp-idf that referenced this pull request Feb 4, 2022
@cc-caixf @dskulina
vfs: fix wrong VFS being freed when esp_vfs_register_fd_range fails
8874a00 
Closes espressif#7413
dskulina pushed a commit to playable-tech/esp-idf that referenced this pull request Feb 5, 2022
@cc-caixf @dskulina
vfs: fix wrong VFS being freed when esp_vfs_register_fd_range fails
b25843a 
Closes espressif#7413
@igrr igrr mentioned this pull request Aug 7, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dobairoland dobairoland dobairoland approved these changes

Assignees

@zikalino zikalino

Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cc-caixf @CLAassistant @Alvin1Zhang @negativekelvin @AxelLin @dobairoland @zikalino @espressif-bot