esp_hid: fix output report char declaration (IDFGH-3402) #5369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current issue: output reports sent by Windows not received. The report characteristic declaration should also support write without response as specified by HIDS profile: See https://www.bluetooth.com/specifications/GATT/ (page 14)
|
@robinkrens Thanks for your contribution. |
me-no-dev
reviewed
Jun 1, 2020
me-no-dev
reviewed
Jun 1, 2020
benjaminaigner
added a commit
to asterics/esp32_mouse_keyboard
that referenced
this pull request
Jul 20, 2020
…(LED report), closing #38 : - Added report ID for LEDs - Added callback event type for LED - Fixed the characteristic & added write no response (according to espressif/esp-idf#5369 THX @robinkrens for the hint!)
|
Hi, @robinkrens Could you please checkout to the 2078dfe and see whether the issue still exist? Thanks |
BetterJincheng
approved these changes
Dec 24, 2021
|
Thanks for your contribution, changes merged with 5f28c0c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
esp_hid: fix output report characteristics declaration
Current issue: output reports sent by Windows not received.
The report characteristic declaration should also support write without
response
As specified by HIDs profile https://www.bluetooth.com/specifications/GATT/
See page 14:
See pull request for suggested changes
Tested under Windows 10 with hidapi
Note: did not test under Linux, because the example at (examples/bluetooth/esp_hid_device)
did not work properly (gap related). Will post additional issue for that.