Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing GATT descriptors (IDFGH-1877) #4082

Closed
wants to merge 1 commit into from

Conversation

bfriedkin
Copy link

Hello -

This PR adds definitions for GATT descriptors 0x2909 (Number of Digitals) through 0x290E (Time Trigger Setting) as defined by the current Bluetooth GATT Descriptors specification:

https://www.bluetooth.com/specifications/gatt/descriptors/

In addition, the new descriptors are added to the btc_gatts_act_create_attr_tab() function, so that server applications can deploy services that include these descriptors, e.g. AIOS service. Without this change, it is not possible to deploy an AIOS service on ESP32/Bluedroid, because some of the required descriptors are missing and hence not added to the attribute table.

Regards,
Brian

@CLAassistant
Copy link

CLAassistant commented Sep 17, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Brian Friedkin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot changed the title Add missing GATT descriptors Add missing GATT descriptors (IDFGH-1877) Sep 17, 2019
@bfriedkin
Copy link
Author

Hello -

Not sure why the Sync to JIRA failed. I did sign the CLA.

Regards,
Brian

@Alvin1Zhang
Copy link
Collaborator

@bfriedkin Thanks for the contribution. We have been fixing some failure cases of Sync. to Jira. We will look into the PR. Thanks.

@GYC-Espressif
Copy link
Contributor

Sorry for the late reply and thank you for your contribution. Due to the limitations of the btc layer, we need to add these UUIDs. Due to synchronization issues, can you resubmit this PR based on the latest master? Or with your consent, we can add it internally. Thank you.

@bfriedkin
Copy link
Author

Hello -

Thank you for the follow-up. I resubmitted this pull request against master as #4470. You can close this PR once #4470 has been merged.

Regards,
Brian

@Alvin1Zhang
Copy link
Collaborator

@bfriedkin Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants