Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace outdated use of c_types.h with stdint #4

Closed
wants to merge 1 commit into from
Closed

Replace outdated use of c_types.h with stdint #4

wants to merge 1 commit into from

Conversation

ESP32DE
Copy link
Contributor

@ESP32DE ESP32DE commented Sep 1, 2016

Replace outdated use of c_types.h with stdint
uint32 -> uint32_t

@ESP32DE
Replace outdated use of c_types.h with stdint
e7eda93 
Replace outdated use of c_types.h with stdint
uint32 -> uint32_t
@projectgus
Copy link
Contributor

Thanks Rudi! I've added this PR and #5 into our internal change queue.

For future reference, if you make changes on the same branch then you can add commits to an existing PR. You don't need to create a new PR each time (but github will do this if you create a new branch each time.)

@ESP32DE
Copy link
Contributor Author

ESP32DE commented Sep 2, 2016

ah - thanks - have not seen "Add more commits by pushing to the" - ok now i know.
you guys are hard working team! where we can - we support you 👍

@ESP32DE ESP32DE closed this Sep 2, 2016
@nathanjel nathanjel mentioned this pull request Jan 15, 2017
Closed
@lollizze lollizze mentioned this pull request Jan 25, 2017
Closed
@nathanjel nathanjel mentioned this pull request Jan 25, 2017
Closed
@kglowacki kglowacki mentioned this pull request Feb 23, 2017
Closed
@hchaudhary1 hchaudhary1 mentioned this pull request Jul 13, 2017
Closed
@karawin karawin mentioned this pull request Oct 6, 2017
Closed
@abhimanyuv1 abhimanyuv1 mentioned this pull request Feb 12, 2018
Closed
@ammaree ammaree mentioned this pull request Apr 20, 2018
Closed
@kluverp kluverp mentioned this pull request Sep 18, 2018
Closed
@ammaree ammaree mentioned this pull request Sep 25, 2018
Closed
@my-abousamra my-abousamra mentioned this pull request Oct 11, 2018
Closed
@markingle markingle mentioned this pull request Dec 4, 2018
Closed
tim-nordell-nimbelink added a commit to tim-nordell-nimbelink/esp-idf that referenced this pull request Feb 28, 2019
@tim-nordell-nimbelink
pm: Fix atomicity of rtos idle lock acquiring
9983c41 
It's possible for esp_pm_impl_isr_hook(...) to be nested due to the fact
that interrupts are nested on the ESP32.  To fix this we need to place the
acquiring of the lock into a critical section to ensure it does not get
nested on the system, otherwise the system will never release the idle
lock when this occurs and will not go into lower power states.

A sample backtrace encountering this (the code was instrumented to go into
a while(1) loop when the condition was hit to get this backtrace) from
commit d7a7a68:

    #0  leave_idle () at esp-idf/components/esp32/pm_esp32.c:444
    espressif#1  0x4008143a in esp_pm_impl_isr_hook () at esp-idf/components/esp32/pm_esp32.c:473
    espressif#2  0x40082750 in _xt_medint2 () at esp-idf/components/freertos/xtensa_vectors.S:1243
    espressif#3  0x4000bff0 in ?? ()
    espressif#4  0x40090bb0 in vTaskExitCritical (mux=0x3ffbd230) at esp-idf/components/freertos/tasks.c:4304
    espressif#5  0x40081758 in esp_pm_lock_acquire (handle=0x3ffbd218) at esp-idf/components/esp32/pm_locks.c:126
    espressif#6  0x40081399 in leave_idle () at esp-idf/components/esp32/pm_esp32.c:440
    espressif#7  0x4008143a in esp_pm_impl_isr_hook () at esp-idf/components/esp32/pm_esp32.c:473
    espressif#8  0x400826b8 in _xt_lowint1 () at esp-idf/components/freertos/xtensa_vectors.S:1154
    espressif#9  0x400d14b0 in esp_pm_impl_waiti () at esp-idf/components/esp32/pm_esp32.c:483
    espressif#10 0x400d2c77 in esp_vApplicationIdleHook () at esp-idf/components/esp32/freertos_hooks.c:63
    espressif#11 0x40091008 in prvIdleTask (pvParameters=0x0) at esp-idf/components/freertos/tasks.c:3412
    espressif#12 0x40090344 in vPortTaskWrapper (pxCode=0x40090ffc <prvIdleTask>, pvParameters=0x0) at esp-idf/components/freertos/port.c:143

Signed-off-by: Tim Nordell <tim.nordell@nimbelink.com>
@Sermus Sermus mentioned this pull request May 11, 2019
Closed
@yavortomov yavortomov mentioned this pull request May 21, 2019
Closed
1 task
@ghost ghost mentioned this pull request Jul 8, 2019
Closed
@iltis42 iltis42 mentioned this pull request Apr 12, 2020
Closed
@joehui joehui mentioned this pull request Jun 4, 2020
Open
@kannannair084 kannannair084 mentioned this pull request Oct 21, 2020
Closed
@iltis42 iltis42 mentioned this pull request Nov 30, 2020
Closed
@norventa norventa mentioned this pull request Apr 12, 2021
Closed
4 tasks
@achao1104 achao1104 mentioned this pull request Sep 17, 2021
Closed
@gadget-man gadget-man mentioned this pull request Oct 8, 2021
Open
@7erduk 7erduk mentioned this pull request Nov 8, 2021
Closed
@achao1104 achao1104 mentioned this pull request Nov 19, 2021
Closed
@sxsx2yzyz sxsx2yzyz mentioned this pull request Apr 15, 2022
Closed
@espressif-bot espressif-bot added the Status: Opened Issue is new label Apr 19, 2022
@patrickwilliamson1 patrickwilliamson1 mentioned this pull request May 4, 2022
Closed
@AxelLin AxelLin mentioned this pull request May 17, 2022
Closed
@espressif-bot espressif-bot added Status: Reviewing Issue is being reviewed and removed Status: Opened Issue is new labels Jun 27, 2022
@espressif-bot espressif-bot added the Status: Opened Issue is new label Aug 9, 2022
@kraa965 kraa965 mentioned this pull request Nov 21, 2022
Closed
@rahult-github rahult-github mentioned this pull request Feb 13, 2023
Closed
@YaswanthKumarSaravanaKumar YaswanthKumarSaravanaKumar mentioned this pull request Mar 31, 2023
Open
3 tasks
@sxsx2yzyz sxsx2yzyz mentioned this pull request May 10, 2023
Closed
3 tasks
@bricomp bricomp mentioned this pull request Jun 21, 2023
Closed
3 tasks
@AxelLin AxelLin mentioned this pull request Jul 16, 2023
Closed
3 tasks
@nomis nomis mentioned this pull request Aug 6, 2023
Closed
3 tasks
@Coopdis Coopdis mentioned this pull request Sep 3, 2023
Closed
@dimonysos dimonysos mentioned this pull request Jan 18, 2024
Closed
3 tasks
@pragulka pragulka mentioned this pull request Sep 9, 2024
Closed
3 tasks
espressif-bot pushed a commit that referenced this pull request Dec 5, 2024
@Lapshin
fix(xtensa): fix confusing backtrace when PC is invalid
244c369 
Before this change _invalid_pc_placeholder pointed to address of _init
function from crti.o
This made GDB input a bit confusing:

  0x40080400 in _init ()
  (gdb) bt
  #0  0x40080400 in _init ()
  #1  0x400e519a in test_instr_fetch_prohibited () at /home/alex/git/esp-idf/tools/test_apps/system/panic/main/test_panic.c:271
  #2  0x400d89a7 in app_main () at /home/alex/git/esp-idf/tools/test_apps/system/panic/main/test_app_main.c:116
  #3  0x400e5f22 in main_task (args=0x0) at /home/alex/git/esp-idf/components/freertos/app_startup.c:208
  #4  0x400895a8 in vPortTaskWrapper (pxCode=0x400e5eb0 <main_task>, pvParameters=0x0) at /home/alex/git/esp-idf/components/freertos/FreeRTOS-Kernel/portable/xtensa/port.c:139

After the change GDB prints output that contains a hint:

  _invalid_pc_placeholder () at /home/alex/git/esp-idf/components/xtensa/xtensa_vectors.S:2235
  2235	    UNREACHABLE_INSTRUCTION_CHECK_PREVIOUS_FRAMES
  (gdb) bt
  #0  _invalid_pc_placeholder () at /home/alex/git/esp-idf/components/xtensa/xtensa_vectors.S:2235
  #1  0x400e519e in test_instr_fetch_prohibited () at /home/alex/git/esp-idf/tools/test_apps/system/panic/main/test_panic.c:271
  #2  0x400d89ab in app_main () at /home/alex/git/esp-idf/tools/test_apps/system/panic/main/test_app_main.c:116
  #3  0x400e5f26 in main_task (args=0x0) at /home/alex/git/esp-idf/components/freertos/app_startup.c:208
  #4  0x400895a8 in vPortTaskWrapper (pxCode=0x400e5eb4 <main_task>, pvParameters=0x0) at /home/alex/git/esp-idf/components/freertos/FreeRTOS-Kernel/portable/xtensa/port.c:139
@vortex314 vortex314 mentioned this pull request Jan 12, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Opened Issue is new Status: Reviewing Issue is being reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ESP32DE @projectgus @espressif-bot