-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't warn if chip version is greater than CONFIG_ESP32_REV_MIN (IDFGH-1778) #4000
Comments
Thanks @ecc1 for your suggestion. We will change it to normal information log ASAP. |
@ecc1 I thought the idea was that by setting a higher minimum version (i.e. to match your chip revision) then fewer workarounds for old revisions need to be enabled. That sounds like good advice, especially if the workarounds cost performance or code size. |
It's a good hint, although better to receive this info at compile time like "This build supports ESP32 REV:0+". Also helpful would be if app binary header had this minimum rev and esptool or OTA would not flash an incompatible binary (@projectgus). Ideally workarounds would be selectively available by compile time config but dynamically enabled at runtime based on detected chip version. Some do have runtime checks, I think. |
You seem to have gained access to our internal repository somehow :) This has been merged recently, should be on Github soon. |
Check chip id and chip revision before boot app image Closes #4000
Check chip id and chip revision before boot app image Closes #4000
Check chip id and chip revision before boot app image Closes espressif#4000
The whole point of this configuration variable is that it's a minimum revision. There's no need to warn if the actual version is greater, and indeed "suggest to upgrade it" is not only bad English, it's bad software engineering advice.
https://github.com/espressif/esp-idf/blob/master/components/esp32/cpu_start.c#L411-L418
The text was updated successfully, but these errors were encountered: