Fixed switch rename issue in examples espressif/esp-rainmaker#152 #7171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
7af3a10 to
201c340
Compare
|
Thanks @sanketwadekar :) looks good! |
Jason2866
added a commit
to Jason2866/arduino-esp32
that referenced
this pull request
Sep 6, 2022
* Enable configuring target variants (espressif#7019) This change enables picking the right board configuration from the variants/ folder. Previously, we would always pick the default configuration (e.g., "esp32" instead of "heltec_wifi_lora_32_V2"). * Update .gitignore (espressif#7021) Add entries to gitignore * Update esptool to version 4.2.1 (espressif#7127) * Update esptool to version 4.2.1 * Fix esptool for MacOS * Esptool v4.2.1 for CI Platformio (espressif#7147) to complete the test. Co-authored-by: Jason2866 <24528715+Jason2866@users.noreply.github.com> * Update get.py to support python 3.10+ (espressif#7166) * Update get.py to support python 3.10+ * Use try/except to remove version check * fixed names on the VID and PID for boards (espressif#7144) somehow had duplicated the same name across all my boards. the PID's and VID's were correct, but the name was the same for all of them. that is fixed now. * Compile error if CONFIG_FREERTOS_HZ != 1000 (espressif#6955) * Compile error if CONFIG_FREERTOS_HZ != 1000 * add a check at the CMake level, per feedback * Set CONFIG_FREERTOS_HZ=1000 in CI test of Arduino-as-component * Adding u-blox NORA-W10 series (ESP32-S3) (espressif#7191) * Create pins_arduino.h * Update boards.txt * Update boards.txt * Fixed espressif/esp-rainmaker#152 (espressif#7171) * Update PlatformIO build scripts (espressif#7200) This update includes the following: - Implemented an additional build step that produces an adjusted bootloader image with updated headers according to selected flash mode and size values. This step is only executed for debugging or uploading via debug probes. - Implemented a basic mechanism to dynamically add an extra UF2 bootloader image if corresponding partition is selected (e.g. for Adafruit targets) - Minor code formatting Co-authored-by: Dr. Christian Kohlschütter <christian@kohlschutter.com> Co-authored-by: Me No Dev <me-no-dev@users.noreply.github.com> Co-authored-by: Paul Price <56952812+strid3r21@users.noreply.github.com> Co-authored-by: Daniel Egnor <egnor@ofb.net> Co-authored-by: Michael Ammann <mazgch@users.noreply.github.com> Co-authored-by: Sanket Wadekar <67091512+sanketwadekar@users.noreply.github.com> Co-authored-by: Valerii Koval <valeros@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue wherein changing the name of switches was not getting reflected in the phone app after the device reboots.
I have tested this on ESP32 using Arduino 2.0.3 and Rainmaker Android app
Closes espressif/esp-rainmaker#152