Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new unphone boards #7058

Merged
merged 0 commits into from
Aug 10, 2022
Merged

Add support for new unphone boards #7058

merged 0 commits into from
Aug 10, 2022

Conversation

garethhcoleman
Copy link
Contributor

First time doing this - please advise if any changes or clarification needed thanks!

Description of Change

Please describe your proposed Pull Request and it's impact.
Adds two new boards, the unPhone spin 8 and spin 9 to boards.txt and variants/unphone8 and variants/unphone9

Tests scenarios

Please describe on what Hardware and Software combinations you have tested this Pull Request and how.
Tested on our prototype hardware with a variety of test sketches, pin assignments seem correct.

Related links

Hardware description at unphone.net and software at https://gitlab.com/hamishcunningham/unphone

@CLAassistant
Copy link

CLAassistant commented Jul 29, 2022

CLA assistant check
All committers have signed the CLA.

@SuGlider
Copy link
Collaborator

SuGlider commented Aug 8, 2022

@garethhcoleman - Please sign the CLA in order to move formward

@SuGlider SuGlider self-assigned this Aug 8, 2022
@SuGlider SuGlider added the Resolution: Awaiting response Waiting for response of author label Aug 8, 2022
@garethhcoleman
Copy link
Contributor Author

@SuGlider thanks for prompt - I didn't realise that!

I will ask my collaborator to also sign.

Thanks again!

@SuGlider
Copy link
Collaborator

SuGlider commented Aug 8, 2022

@hamishcunningham - Please sign the CLA in order to move forward

@SuGlider
Copy link
Collaborator

SuGlider commented Aug 8, 2022

@garethhcoleman @hamishcunningham

It seems that there are some conflicts when merging boards.txt file because other vendors have already made their changes and those are already merged into the master branch. I think you may need to "rebase" your local repository and pull latest master branch from ESP32 in order to get the last version of boards.txt and just add your board entries at the end.

When done commit the changes and we will merge it to main master branch.

@garethhcoleman garethhcoleman merged commit 3cb73dc into espressif:master Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants