-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Wire::setBufferSize function #7016
Conversation
If the size doesn't need to be changed at runtime, perhaps this could be done with a template size, so you don't have to use up more heap memory?
edit - nevermind, this would be breaking before c++ '17, as you would be required to put the <> |
Arduino APIs use to be "user proof" also... So creating an API with all necessary checks is safer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, will test tomorrow :) take a look on my comments @SuGlider
fixes begin() in case of error
Adds some `defines` that let the application know what fucntionalitites are avilable in Wire and make it more portable among different platforms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :) Good job @SuGlider
Description of Change
Adds a new Wire (I2C) functionality to set the RX/TX buffer size and change it any time in the sketch.
Some I2C devices and sensors may require a bigger buffer for its transactions.
Tests scenarios
Related links
Fixes #6967
Fixes #7042