Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added NVS test sketch + test script #6885

Merged
merged 12 commits into from
Aug 15, 2022
Merged

Added NVS test sketch + test script #6885

merged 12 commits into from
Aug 15, 2022

Conversation

P-R-O-C-H-Y
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y commented Jun 20, 2022 •
edited
Loading

Description of Change

Added simple NVS test.

Related links

#6884

Important

Before each release, this NVS test needs to be locally builded + run on ESP32S3 with Octal Flash.

Command to build with custom FQBN (cfg.json will be excluded from building):
./.github/scripts/tests_build.sh -s nvs -t esp32s3 -fqbn espressif:esp32:esp32s3:PSRAM=opi,USBMode=default,PartitionScheme=huge_app,FlashMode=opi

Command to run:
./.github/scripts/tests_run.sh -s nvs -t esp32s3 -e -o

@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Jun 20, 2022
@me-no-dev me-no-dev added the hil_test Run Hardware Tests label Jun 24, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 24, 2022 •
edited
Loading

Unit Test Results

17 files  17 suites   3m 15s ⏱️
  8 tests   8 ✔️ 0 💤 0 ❌
22 runs  22 ✔️ 0 💤 0 ❌

Results for commit f8888ab.

♻️ This comment has been updated with latest results.

@me-no-dev
Copy link
Member

@P-R-O-C-H-Y flash modes are working now in the 4.4 branch. You can test against that and master if you want to verify that it fails on one, but not the other. cc: @Ouss4

@P-R-O-C-H-Y
Copy link
Member Author

P-R-O-C-H-Y commented Jun 27, 2022 •
edited
Loading

@me-no-dev Can confirm that on C3 and S3 all modes are again working on idf-release/v4.4 branch. Great job!

@me-no-dev
Copy link
Member

FQBN Additions:

  • ESP32-S3: FlashMode=[qio|qio120|dio|opi]
  • Rest: FlashMode=[qio|qout|dio|dout],FlashFreq=[40|80]

@me-no-dev
Copy link
Member

There is a problem with the test @P-R-O-C-H-Y . Since the value is in NVS, it is probably already set to something from previous run and will never again start from 0, so what the test expects will fail (as it did). Maybe you need to rethink the test or find a way to erase flash prior to running the test.

@P-R-O-C-H-Y
Copy link
Member Author

We are waiting for @Ouss4 to make a PR with a few CI changes. One will be the flash erase so the test will work after that PR ;)

@Ouss4 Ouss4 mentioned this pull request Jun 27, 2022
Merged
@lbernstone
Copy link
Contributor

Not to derail this pr, but is there actually eqpt out there that will only run on dout/qout?

@me-no-dev
Copy link
Member

Not to derail this pr, but is there actually eqpt out there that will only run on dout/qout?

yes. I have a board that has flash which can do only dout. It's very rare, but exists and also can free up some IO if you do not need the throughput.

@lbernstone
Copy link
Contributor

Not to derail this pr, but is there actually eqpt out there that will only run on dout/qout?

yes. I have a board that has flash which can do only dout. It's very rare, but exists and also can free up some IO if you do not need the throughput.

Ok, just asking. I have some cheap sh!t in my bin, and I've never seen it 😄

@VojtechBartoska VojtechBartoska added this to the 2.0.4 milestone Jun 29, 2022
@hfudev hfudev mentioned this pull request Jun 30, 2022
Merged
@VojtechBartoska VojtechBartoska modified the milestones: 2.0.4, 2.1.0 Jul 11, 2022
@VojtechBartoska VojtechBartoska added the Status: Pending Merge Pull Request is ready to be merged label Jul 13, 2022
@P-R-O-C-H-Y P-R-O-C-H-Y added hil_test Run Hardware Tests and removed hil_test Run Hardware Tests labels Jul 15, 2022
@VojtechBartoska VojtechBartoska modified the milestones: 2.1.0, 2.0.5 Jul 18, 2022
@VojtechBartoska
Copy link
Contributor

Status update: Blocked by missing HW on our runners.

@P-R-O-C-H-Y P-R-O-C-H-Y removed the Status: Pending Merge Pull Request is ready to be merged label Jul 21, 2022
@VojtechBartoska VojtechBartoska modified the milestones: 2.0.5, 2.1.0 Jul 27, 2022
@P-R-O-C-H-Y P-R-O-C-H-Y modified the milestones: 2.1.0, 2.0.5 Aug 10, 2022
@P-R-O-C-H-Y
Copy link
Member Author

Status update: Hw will be installed tomorrow morning.

@VojtechBartoska
Copy link
Contributor

To-Do:

  • Write down internal Wiki page about "How to release"

@VojtechBartoska VojtechBartoska self-assigned this Aug 15, 2022
@P-R-O-C-H-Y P-R-O-C-H-Y merged commit ac7879c into espressif:master Aug 15, 2022
@P-R-O-C-H-Y P-R-O-C-H-Y deleted the NVS_Flash_CI_test branch August 15, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@VojtechBartoska VojtechBartoska

@P-R-O-C-H-Y P-R-O-C-H-Y

Labels
hil_test Run Hardware Tests Type: CI & Testing
Projects
Arduino ESP32 Core Project Roadmap
Status: Done
Milestone
2.0.5
Development

Successfully merging this pull request may close these issues.
4 participants
@P-R-O-C-H-Y @me-no-dev @lbernstone @VojtechBartoska