-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement simple RGB driver via digitalWrite; solving #6783 #6808
Changes from all commits
6967d8f
cd31356
51ce37d
1e363b7
50b6356
583e030
8786e83
10205b0
c0aa3b8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
#include "esp32-hal-rgb-led.h" | ||
|
||
|
||
void neopixelWrite(uint8_t pin, uint8_t red_val, uint8_t green_val, uint8_t blue_val){ | ||
rmt_data_t led_data[24]; | ||
static rmt_obj_t* rmt_send = NULL; | ||
static bool initialized = false; | ||
|
||
uint8_t _pin = pin; | ||
#ifdef BOARD_HAS_NEOPIXEL | ||
if(pin == LED_BUILTIN){ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this should be evaluated only if the board has neopixel, else LED_BUILTIN would be lower than SOC_GPIO_PIN_COUNT There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The entire function was safeguarded |
||
_pin = LED_BUILTIN-SOC_GPIO_PIN_COUNT; | ||
} | ||
#endif | ||
|
||
if(!initialized){ | ||
if((rmt_send = rmtInit(_pin, RMT_TX_MODE, RMT_MEM_64)) == NULL){ | ||
log_e("RGB LED driver initialization failed!"); | ||
rmt_send = NULL; | ||
return; | ||
} | ||
rmtSetTick(rmt_send, 100); | ||
initialized = true; | ||
} | ||
|
||
int color[] = {green_val, red_val, blue_val}; // Color coding is in order GREEN, RED, BLUE | ||
int i = 0; | ||
for(int col=0; col<3; col++ ){ | ||
for(int bit=0; bit<8; bit++){ | ||
if((color[col] & (1<<(7-bit)))){ | ||
// HIGH bit | ||
led_data[i].level0 = 1; // T1H | ||
led_data[i].duration0 = 8; // 0.8us | ||
led_data[i].level1 = 0; // T1L | ||
led_data[i].duration1 = 4; // 0.4us | ||
}else{ | ||
// LOW bit | ||
led_data[i].level0 = 1; // T0H | ||
led_data[i].duration0 = 4; // 0.4us | ||
led_data[i].level1 = 0; // T0L | ||
led_data[i].duration1 = 8; // 0.8us | ||
} | ||
i++; | ||
} | ||
} | ||
rmtWrite(rmt_send, led_data, 24); | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
#ifndef MAIN_ESP32_HAL_RGB_LED_H_ | ||
#define MAIN_ESP32_HAL_RGB_LED_H_ | ||
|
||
#ifdef __cplusplus | ||
extern "C" { | ||
#endif | ||
|
||
#include "esp32-hal.h" | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You should have safeguard against LED_BRIGHTNESS not being defined: #ifndef LED_BRIGHTNESS
#define LED_BRIGHTNESS 64
#endif |
||
#ifndef LED_BRIGHTNESS | ||
#define LED_BRIGHTNESS 64 | ||
#endif | ||
|
||
void neopixelWrite(uint8_t pin, uint8_t red_val, uint8_t green_val, uint8_t blue_val); | ||
|
||
#ifdef __cplusplus | ||
} | ||
#endif | ||
|
||
#endif /* MAIN_ESP32_HAL_RGB_LED_H_ */ |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
/* | ||
BlinkRGB | ||
|
||
Demonstrates usage of onboard RGB LED on some ESP dev boards. | ||
|
||
Calling digitalWrite(LED_BUILTIN, HIGH) will use hidden RGB driver. | ||
|
||
RGBLedWrite demonstrates controll of each channel: | ||
void neopixelWrite(uint8_t pin, uint8_t red_val, uint8_t green_val, uint8_t blue_val) | ||
|
||
WARNING: After using digitalWrite to drive RGB LED it will be impossible to drive the same pin | ||
with normal HIGH/LOW level | ||
*/ | ||
//#define LED_BRIGHTNESS 64 // Change white brightness (max 255) | ||
|
||
// the setup function runs once when you press reset or power the board | ||
|
||
void setup() { | ||
// No need to initialize the RGB LED | ||
} | ||
|
||
// the loop function runs over and over again forever | ||
void loop() { | ||
#ifdef BOARD_HAS_NEOPIXEL | ||
digitalWrite(LED_BUILTIN, HIGH); // Turn the RGB LED white | ||
delay(1000); | ||
digitalWrite(LED_BUILTIN, LOW); // Turn the RGB LED off | ||
delay(1000); | ||
|
||
neopixelWrite(LED_BUILTIN,LED_BRIGHTNESS,0,0); // Red | ||
delay(1000); | ||
neopixelWrite(LED_BUILTIN,0,LED_BRIGHTNESS,0); // Green | ||
delay(1000); | ||
neopixelWrite(LED_BUILTIN,0,0,LED_BRIGHTNESS); // Blue | ||
delay(1000); | ||
neopixelWrite(LED_BUILTIN,0,0,0); // Off / black | ||
delay(1000); | ||
#endif | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we consider moving the board-specific code to the
variants
folder?I'm worried that the more similar features we add for specific boards, the more complex the core code will become. It would be better to handle this in the board variant folder. It would also demonstrate authors of 3rd party board packages how to add such custom functionality.
To avoid duplication of code, you can still define
RGBLedWrite
somewhere in the core, but preferably in a separate source file (esp32-hal-rgb-led.c?)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little bit confused about what should go where.
pinMode
->variants/
... new file?RGBLedWrite
->esp32-hal-rgb-led.c
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be solved in 583e030