Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testing): Checkout proper branch for Wokwi tests and small QoL improvements #10435

Merged
merged 7 commits into from
Oct 21, 2024

Conversation

lucasssvaz
Copy link
Collaborator

@lucasssvaz lucasssvaz commented Oct 8, 2024

Description of Change

  • Fixes Wokwi test so it will check out the proper base branch where the PR is being merged
  • Add logging to some tests
  • Fixes debug output of some tests
  • Improve fibonacci test
  • Remove redundant targets from some tests JSON
  • Make DangerJS more permissive and improve some CI messages
  • Update pytest-embedded to support P4

Testing

Local and CI in fork

Copy link
Contributor

github-actions bot commented Oct 8, 2024

Warnings
⚠️ Please consider squashing your 7 commits (simplifying branch history).

👋 Hello lucasssvaz, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 10afaf0

Copy link
Contributor

github-actions bot commented Oct 8, 2024

Test Results

 56 files   56 suites   4m 8s ⏱️
 21 tests  21 ✅ 0 💤 0 ❌
134 runs  134 ✅ 0 💤 0 ❌

Results for commit 10afaf0.

♻️ This comment has been updated with latest results.

@lucasssvaz lucasssvaz added the Status: Review needed Issue or PR is awaiting review label Oct 17, 2024
@me-no-dev
Copy link
Member

This will cause merge issues into 3.1. We can merge it when you are online @lucasssvaz

@me-no-dev me-no-dev merged commit 9e643c0 into espressif:master Oct 21, 2024
26 of 27 checks passed
@lucasssvaz lucasssvaz deleted the feat/qol branch October 21, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Review needed Issue or PR is awaiting review Type: CI & Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants