Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(networking): NetworkClientRxBuffer::clear() may not always clear #10331

Merged
merged 1 commit into from
Sep 13, 2024
Merged

fix(networking): NetworkClientRxBuffer::clear() may not always clear #10331

merged 1 commit into from
Sep 13, 2024

Conversation

TD-er
Copy link
Contributor

@TD-er TD-er commented Sep 11, 2024

Description of Change

See discussion in issue #10288

Related links

Fixes: #10288

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 11, 2024 •
edited
Loading

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "NetworkClientRxBuffer::clear() may not always clear (#10288)":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello TD-er, we appreciate your contribution to this project!

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 2835ceb

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 11, 2024 •
edited
Loading

Test Results

 56 files   -  83   56 suites   - 83   4m 55s ⏱️ - 1h 37m 28s
 21 tests  -   9   21 ✅  -   9  0 💤 ±0  0 ❌ ±0 
135 runs   - 168  135 ✅  - 168  0 💤 ±0  0 ❌ ±0 

Results for commit 2835ceb. ± Comparison against base commit 4e9eb35.

This pull request removes 9 tests. 
performance.coremark.test_coremark ‑ test_coremark
performance.fibonacci.test_fibonacci ‑ test_fibonacci
performance.psramspeed.test_psramspeed ‑ test_psramspeed
performance.ramspeed.test_ramspeed ‑ test_ramspeed
performance.superpi.test_superpi ‑ test_superpi
test_touch_errors
test_touch_interrtupt
test_touch_read
validation.periman.test_periman ‑ test_periman

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S3💚 -16⚠️ +120.000.00000.000.00
ESP32S2💚 -24⚠️ +120.000.00000.000.00
ESP32C30⚠️ +120.000.00000.000.00
ESP32C60⚠️ +100.000.00000.000.00
ESP32H20⚠️ +100.000.00000.000.00
ESP320⚠️ +160.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
Ethernet/examples/ETH_W5500_Arduino_SPI0000⚠️ +100⚠️ +100⚠️ +100⚠️ +160
Ethernet/examples/ETH_W5500_IDF_SPI0000⚠️ +100⚠️ +100⚠️ +100⚠️ +120
Ethernet/examples/ETH_WIFI_BRIDGE00000000--00
NetworkClientSecure/examples/WiFiClientInsecure0000⚠️ +100⚠️ +100--⚠️ +120
NetworkClientSecure/examples/WiFiClientPSK0000⚠️ +100⚠️ +100--⚠️ +120
NetworkClientSecure/examples/WiFiClientSecure0000⚠️ +100⚠️ +100--⚠️ +120
NetworkClientSecure/examples/WiFiClientSecureEnterprise0000⚠️ +100⚠️ +100--⚠️ +120
NetworkClientSecure/examples/WiFiClientSecureProtocolUpgrade00⚠️ +120⚠️ +100⚠️ +100--⚠️ +120
NetworkClientSecure/examples/WiFiClientShowPeerCredentials💚 -16000⚠️ +100⚠️ +100--⚠️ +120
NetworkClientSecure/examples/WiFiClientTrustOnFirstUse0000⚠️ +100⚠️ +100--00
PPP/examples/PPP_Basic0000⚠️ +100⚠️ +100⚠️ +100⚠️ +120
PPP/examples/PPP_WIFI_BRIDGE00000000--00
WebServer/examples/AdvancedWebServer0000⚠️ +100⚠️ +100--⚠️ +120
WebServer/examples/FSBrowser0000⚠️ +100⚠️ +100--⚠️ +120
WebServer/examples/Filters⚠️ +40⚠️ +120⚠️ +100⚠️ +100--⚠️ +120
WebServer/examples/HelloServer0000⚠️ +100⚠️ +100--⚠️ +120
WebServer/examples/HttpAdvancedAuth0000⚠️ +100⚠️ +100--⚠️ +120
WebServer/examples/HttpAuthCallback0000⚠️ +100⚠️ +100--⚠️ +120
WebServer/examples/HttpAuthCallbackInline0000⚠️ +100⚠️ +100--⚠️ +120
WebServer/examples/HttpBasicAuth0000⚠️ +100⚠️ +100--⚠️ +120
WebServer/examples/HttpBasicAuthSHA10000⚠️ +120⚠️ +100--⚠️ +120
WebServer/examples/HttpBasicAuthSHA1orBearerToken0000⚠️ +100⚠️ +100--⚠️ +120
WebServer/examples/MultiHomedServers00⚠️ +120⚠️ +100⚠️ +100--⚠️ +120
WebServer/examples/PathArgServer⚠️ +12000⚠️ +100⚠️ +100--⚠️ +120
WebServer/examples/SDWebServer0000⚠️ +100⚠️ +100--⚠️ +120
WebServer/examples/SimpleAuthentification0000⚠️ +100⚠️ +100--⚠️ +160
WebServer/examples/UploadHugeFile00💚 -240⚠️ +100⚠️ +100--00
WebServer/examples/WebServer⚠️ +12000⚠️ +100⚠️ +100--⚠️ +40
WebServer/examples/WebUpdate0000⚠️ +100⚠️ +100--⚠️ +120
WiFi/examples/FTM/FTM_Initiator00000000--00
WiFi/examples/FTM/FTM_Responder00000000--00
WiFi/examples/SimpleWiFiServer⚠️ +12000⚠️ +100⚠️ +100--⚠️ +120
WiFi/examples/WPS00000000--00
WiFi/examples/WiFiAccessPoint0000⚠️ +100⚠️ +100--⚠️ +160
WiFi/examples/WiFiBlueToothSwitch00--0000--00
WiFi/examples/WiFiClient0000⚠️ +100⚠️ +100--⚠️ +120
WiFi/examples/WiFiClientBasic0000⚠️ +100⚠️ +100--⚠️ +120
WiFi/examples/WiFiClientConnect00000000--00
WiFi/examples/WiFiClientEnterprise0000⚠️ +100⚠️ +100--⚠️ +120
WiFi/examples/WiFiClientEvents00000000--00
WiFi/examples/WiFiClientStaticIP⚠️ +12000⚠️ +100⚠️ +100--⚠️ +120
WiFi/examples/WiFiExtender00000000--00
WiFi/examples/WiFiIPv600000000--00
WiFi/examples/WiFiMulti00000000--00
WiFi/examples/WiFiMultiAdvanced0000⚠️ +100⚠️ +100--⚠️ +120
WiFi/examples/WiFiScan00000000--00
WiFi/examples/WiFiScanAsync00000000--00
WiFi/examples/WiFiScanDualAntenna00000000--00
WiFi/examples/WiFiScanTime00000000--00
WiFi/examples/WiFiSmartConfig00000000--00
WiFi/examples/WiFiTelnetToSerial0000⚠️ +100⚠️ +100--⚠️ +120
WiFi/examples/WiFiUDPClient00000000--00
Ethernet/examples/ETH_LAN8720----------⚠️ +120
Ethernet/examples/ETH_TLK110----------⚠️ +120

@me-no-dev me-no-dev added the Status: Pending Merge Pull Request is ready to be merged label Sep 12, 2024
@VojtechBartoska VojtechBartoska changed the title 10288 NetworkClientRxBuffer::clear() may not always clear fix(networking): NetworkClientRxBuffer::clear() may not always clear Sep 12, 2024
@VojtechBartoska VojtechBartoska added the Area: WiFi Issue related to WiFi label Sep 12, 2024
@VojtechBartoska VojtechBartoska added this to the 3.0.5 milestone Sep 12, 2024
@me-no-dev me-no-dev merged commit 8a87df3 into espressif:master Sep 13, 2024
83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

@me-no-dev me-no-dev me-no-dev approved these changes

Assignees
No one assigned
Labels
Area: WiFi Issue related to WiFi Status: Pending Merge Pull Request is ready to be merged
Projects
None yet
Milestone
3.0.5
Development

Successfully merging this pull request may close these issues.

NetworkClientRxBuffer::clear() may not always clear
4 participants
@TD-er @me-no-dev @P-R-O-C-H-Y @VojtechBartoska