Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pre-commit): Add JSON formatter to pre-commit hooks #10324

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

lucasssvaz
Copy link
Collaborator

Description of Change

Added JSON formatter to pre-commit and apply fixes.

Tests scenarios

Tested locally

@lucasssvaz lucasssvaz added Type: CI & Testing Area: Tools & Build System Issue is related to tools and/or the build system labels Sep 10, 2024
@lucasssvaz lucasssvaz self-assigned this Sep 10, 2024
Copy link
Contributor

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello lucasssvaz, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 4513497

Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S3000.000.00000.000.00
ESP32C3000.000.00000.000.00
ESP32C6000.000.00000.000.00
ESP32H2000.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3ESP32C3ESP32C6ESP32H2
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAM
ESP32/examples/HWCDC_Events00000000
ESP_SR/examples/Basic00------
SD_MMC/examples/SD2USBMSC00------
OpenThread/examples/COAP/coap_lamp----0000
OpenThread/examples/COAP/coap_switch----0000
OpenThread/examples/SimpleCLI----0000
OpenThread/examples/SimpleNode----0000
OpenThread/examples/SimpleThreadNetwork/ExtendedRouterNode----0000
OpenThread/examples/SimpleThreadNetwork/LeaderNode----0000
OpenThread/examples/SimpleThreadNetwork/RouterNode----0000
OpenThread/examples/ThreadScan----0000
OpenThread/examples/onReceive----0000

Copy link
Contributor

github-actions bot commented Sep 10, 2024

Test Results

 56 files   -  83   56 suites   - 83   4m 42s ⏱️ - 1h 37m 32s
 21 tests  -   9   21 ✅  -   9  0 💤 ±0  0 ❌ ±0 
135 runs   - 168  135 ✅  - 168  0 💤 ±0  0 ❌ ±0 

Results for commit 4513497. ± Comparison against base commit 1e04762.

This pull request removes 9 tests.
performance.coremark.test_coremark ‑ test_coremark
performance.fibonacci.test_fibonacci ‑ test_fibonacci
performance.psramspeed.test_psramspeed ‑ test_psramspeed
performance.ramspeed.test_ramspeed ‑ test_ramspeed
performance.superpi.test_superpi ‑ test_superpi
test_touch_errors
test_touch_interrtupt
test_touch_read
validation.periman.test_periman ‑ test_periman

♻️ This comment has been updated with latest results.

@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label Sep 11, 2024
@me-no-dev me-no-dev merged commit 4e9eb35 into espressif:master Sep 11, 2024
65 of 68 checks passed
@lucasssvaz lucasssvaz deleted the ci/json_pretty branch September 15, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Tools & Build System Issue is related to tools and/or the build system Status: Pending Merge Pull Request is ready to be merged Type: CI & Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants