-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(arduino): changes ESP32 definition in CMakeLists.txt file #10259
Conversation
Fixes an issue related to ESP_MATTER component that defines a path using ESP32 as folder. Because Arduino defines ESP32 to 1, it causes an expansion error for folder using ESP32 folder name.
👋 Hello SuGlider, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
@SuGlider PR brakes compability with pioarduino/Platformio. It causes masses of redefine warnings
|
As it used before it was just a compile flag setting. Since Matter is currently not supported nor working imho the PR should reverted until a non conflicting solution is found. EDIT: Probably fixed with espressif/esp32-arduino-lib-builder#217 |
Yes, espressif/esp32-arduino-lib-builder#217 will fix PIO adding |
Description of Change
Fixes an issue related to
esp_matter
component that defines a path usingESP32
as folder.Because Arduino defines
ESP32
to1
, it causes an expansion error for folder usingESP32
folder name.-DESP32
==>#define ESP32 1
#define CHIP_PLATFORM_CONFIG_INCLUDE <platform/ESP32/CHIPPlatformConfig.h>
will expand to
#define CHIP_PLATFORM_CONFIG_INCLUDE <platform/1/CHIPPlatformConfig.h>
Tests scenarios
Building Arduino + Matter as IDF Component in the same project.
Related links
#7432 (comment)