Fix use after free in SD library

[Ariakenom]

Description of Change

The destructor of AcquireSPI uses card after card has been freed.

The issue causes constant crashes for me.

(Sidenote: s_cards[pdrv] is accessed before pdrv is checked to be valid throughout the file)

Tests scenarios

Tested on a ESP32-S3 via platformio framework "espidf, arduino".

Related links

Introduced in b6ca5a8

[CLAassistant]

All committers have signed the CLA.

[github-actions]

Warnings

⚠️

Some issues found for the commit messages in this PR: the commit message "fix(sd): Fix use after free": summary looks too short Please fix these commit messages - here are some basic tips: follow Conventional Commits style correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter avoid Jira references in commit messages (unavailable/irrelevant for our customers) TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello Ariakenom, we appreciate your contribution to this project!

---

Click to see more instructions ...

This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 60e9415

[P-R-O-C-H-Y]

Looking good :), will test before marking as Pending merge.

[github-actions]

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

Memory	FLASH [bytes]		FLASH [%]		RAM [bytes]		RAM [%]
Target	DEC	INC	DEC	INC	DEC	INC	DEC	INC
ESP32S3	💚 -12	0	0.00	0.00	0	0	0.00	0.00
ESP32S2	💚 -12	0	0.00	0.00	0	0	0.00	0.00
ESP32C3	💚 -4	0	0.00	0.00	0	0	0.00	0.00
ESP32C6	💚 -4	0	0.00	0.00	0	0	0.00	0.00
ESP32H2	💚 -4	0	0.00	0.00	0	0	0.00	0.00
ESP32	💚 -4	0	0.00	0.00	0	0	0.00	0.00

Click to expand the detailed deltas report [usage change in BYTES]

Target	ESP32S3		ESP32S2		ESP32C3		ESP32C6		ESP32H2		ESP32
Example	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM
SD/examples/SD_Test	0	0	0	0	💚 -4	0	💚 -4	0	💚 -4	0	💚 -4	0
SD/examples/SD_time	💚 -12	0	💚 -12	0	💚 -4	0	💚 -4	0	-	-	0	0

[github-actions]

Test Results

 56 files   -  83   56 suites   - 83   5m 15s ⏱️ - 1h 37m 54s
 21 tests  -   9   21 ✅  -   9  0 💤 ±0  0 ❌ ±0 
135 runs   - 168  135 ✅  - 168  0 💤 ±0  0 ❌ ±0 

Results for commit 60e9415. ± Comparison against base commit 70786dc.

This pull request removes 9 tests.

performance.coremark.test_coremark ‑ test_coremark
performance.fibonacci.test_fibonacci ‑ test_fibonacci
performance.psramspeed.test_psramspeed ‑ test_psramspeed
performance.ramspeed.test_ramspeed ‑ test_ramspeed
performance.superpi.test_superpi ‑ test_superpi
test_touch_errors
test_touch_interrtupt
test_touch_read
validation.periman.test_periman ‑ test_periman

♻️ This comment has been updated with latest results.

[cekanayake74]

Very Much grateful for this fix. Can confirm working on WT32-ETH01. Arduino as component of ESP-IDF Ver4.4.7 on VScode.