Skip to content

Commit

Permalink
.github: Fix building chunks.
Browse files Browse the repository at this point in the history
Multiple arguments and options were not set correctly.

Signed-off-by: Abdelatif Guettouche <abdelatif.guettouche@espressif.com>
  • Loading branch information
Ouss4 committed Jun 27, 2022
1 parent 1d107aa commit 168e236
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 5 deletions.
9 changes: 4 additions & 5 deletions .github/scripts/on-push.sh
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ function build(){

local args="-ai $ARDUINO_IDE_PATH -au $ARDUINO_USR_PATH"

args+=" -fqbn $fqbn"
args+=" -t $target -fqbn $fqbn"

if [ "$OS_IS_LINUX" == "1" ]; then
args+=" $ARDUINO_ESP32_PATH/libraries"
args+=" $chunk_index $chunks_cnt"
args+=" -p $ARDUINO_ESP32_PATH/libraries"
args+=" -i $chunk_index -m $chunks_cnt"
${BUILD_SKETCHES} ${args}
else
if [ "$OS_IS_WINDOWS" == "1" ]; then
Expand All @@ -32,8 +32,7 @@ function build(){
fi

for sketch in ${sketches}; do
args+=" -s $sketch"
${BUILD_SKETCH} ${args}
${BUILD_SKETCH} ${args} " -s $sketch"
done
fi
}
Expand Down
5 changes: 5 additions & 0 deletions .github/scripts/sketch_utils.sh
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,11 @@ function build_sketch(){ # build_sketch <ide_path> <user_path> <path-to-ino> [ex
fqbn+=$opts
fqbn="[\"$fqbn\"]"
fi
else
# An FQBN was passed. Make it look like a JSON array.

len=1
fqbn="[\"$fqbn\"]"
fi

if [ -z "$fqbn" ]; then
Expand Down

0 comments on commit 168e236

Please sign in to comment.