-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bme280.rst with CSB pin hint #4439
Conversation
Add warning to check connection diagram, since leaving CSB non-pulled will result in dropping out of I2C mode after some time after start.
✅ Deploy Preview for esphome ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
WalkthroughThe pull request updates the documentation for the BME280 sensor platform, specifically adding a note about the I²C mode configuration. It recommends pulling the CSB pin to 3V to prevent communication errors with the BME280 sensor. The rest of the documentation remains unchanged, including configuration examples and variable descriptions. Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
components/sensor/bme280.rst (1)
16-17
: LGTM! Consider adding a direct link to the connection diagram section.The added note effectively warns users about the CSB pin configuration issue and provides the exact error message they might encounter. The placement and formatting are appropriate.
Consider adding the specific section number from the datasheet for quicker reference:
-**Note:** In :ref:`I²C <i2c>` mode pulling CSB to 3V is recommended, in order to avoid ``[E][sensor.bme280:155]: Communication with BME280 failed!`` error. See the *Connection diagram* chapter in datasheet above. +**Note:** In :ref:`I²C <i2c>` mode pulling CSB to 3V is recommended, in order to avoid ``[E][sensor.bme280:155]: Communication with BME280 failed!`` error. See the *Connection diagram* in Section 6.2 of the datasheet above.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
components/sensor/bme280.rst
(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
components/sensor/bme280.rst (1)
Pattern **
: - Do not generate or add any sequence diagrams
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @kotylo 👍
../Frenck
Add warning to check connection diagram, since leaving CSB non-pulled will result in dropping out of I2C mode after some time after start.
Description:
Related issue (if applicable): fixes
Pull request in esphome with YAML changes (if applicable): esphome/esphome#
Checklist:
I am merging into
next
because this is new documentation that has a matching pull-request in esphome as linked above.or
I am merging into
current
because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.Link added in
/index.rst
when creating new documents for new components or cookbook.