Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usage of response in http_request.rst samples #3933

Closed
wants to merge 1 commit into from

Conversation

glmnet
Copy link
Member

@glmnet glmnet commented Jun 10, 2024

Description:

Simple fixes of http request samples as I'm testing now, the response object is in shared pointer so it needs the arrow operator

error: 'class std::shared_ptr<esphome::http_request::HttpContainer>' has no member named 'status_code'

@probot-esphome probot-esphome bot added the next label Jun 10, 2024
Copy link

netlify bot commented Jun 10, 2024

Deploy Preview for esphome ready!

Name Link
🔨 Latest commit fbb5fe3
🔍 Latest deploy log https://app.netlify.com/sites/esphome/deploys/666763d8eaaa390008e2e8bc
😎 Deploy Preview https://deploy-preview-3933--esphome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jesserockz
Copy link
Member

Woops, did not see this. Sorry @glmnet. Thanks for trying to update it.

It got merged in #4049

@jesserockz jesserockz closed this Jul 22, 2024
@jesserockz jesserockz deleted the glmnet-fix-http-response branch July 22, 2024 04:32
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants