-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend the UDP message sender Cookbook with 8266 example #3924
base: current
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for esphome ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
WalkthroughThe changes to Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ESPHomeScript
participant ESP8266
participant ESP32
User->>ESPHomeScript: Trigger UDP command
ESPHomeScript->>ESP8266: Send UDP packet (ESP8266 logic)
ESPHomeScript->>ESP32: Send UDP packet (ESP32 logic)
ESP8266-->>ESPHomeScript: UDP packet sent
ESP32-->>ESPHomeScript: UDP packet sent
ESPHomeScript-->>User: Confirmation of UDP packet sent
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (2)
cookbook/lambda_magic.rst (2)
Line range hint
64-101
: The updated UDP command sending examples for both ESP8266 and ESP32 are clear and well-segmented.However, consider adding a brief explanation or comment in the YAML to clarify why
WiFiUdp.h
is specifically needed for ESP8266, as this might not be immediately obvious to all users.
67-67
: The inclusion ofWiFiUdp.h
is correctly documented.Consider adding a link to the WiFiUdp library documentation or source for users who might want more detailed information about its functionality.
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
Description:
Extended the configuration example of "Send UDP commands" cookbook entry form the "Lambda Magic" chapter with working yaml for ESP8266. This is important because many think that the WiFi implementation of ESP8266 lacks UDP, but WiFiUdp library comes to help with a simple inclusion (which btw is used by two other components).
Related issue (if applicable): fixes
Pull request in esphome with YAML changes (if applicable): esphome/esphome#
Checklist:
I am merging into
next
because this is new documentation that has a matching pull-request in esphome as linked above.or
I am merging into
current
because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.Link added in
/index.rst
when creating new documents for new components or cookbook.